This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ARM patch: Split compare_scc (PR42835)


On 03/07/10 13:15, Bernd Schmidt wrote:
On 07/03/2010 01:46 PM, Bernd Schmidt wrote:
Tested with my usual set of multilibs on QEMU arm-linux. Ok?

And here's the patch file. I think I need to hack Thunderbird somehow to recognize more phrases for the "missing attachment" warning.


Bernd

This is OK with one minor nit. Please can you put something in the pattern names that distinguishes which variant of the iterator the pattern was expanded for. For example:


+(define_insn "*addsi3_carryin_shift"
   [(set (match_operand:SI 0 "s_register_operand" "=r")
+	(plus:SI (plus:SI
+		  (match_operator:SI 2 "shift_operator"
+		    [(match_operand:SI 3 "s_register_operand" "r")
+		     (match_operand:SI 4 "reg_or_int_operand" "rM")])
+		  (match_operand:SI 1 "s_register_operand" "r"))
+		 (LTUGEU:SI (reg:<cnb> CC_REGNUM) (const_int 0))))]

Should use something like

+(define_insn "*addsi3_carryin_<optab>_shift"
   [(set (match_operand:SI 0 "s_register_operand" "=r")
+	(plus:SI (plus:SI
+		  (match_operator:SI 2 "shift_operator"
+		    [(match_operand:SI 3 "s_register_operand" "r")
+		     (match_operand:SI 4 "reg_or_int_operand" "rM")])
+		  (match_operand:SI 1 "s_register_operand" "r"))
+		 (LTUGEU:SI (reg:<cnb> CC_REGNUM) (const_int 0))))]

Where optab expands to ltu or geu as appropriate.

(I think you'll need to define the optab attribute -- pity that that isn't a default one).

R.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]