This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Add new warning -Wtrampolines


Magnus,

Was this reviewed? If nobody offers to commit it, I will try to find
some time to do it.

Cheers,

Manuel.

On 18 June 2010 04:02, Magnus Granberg <zorry@gentoo.org> wrote:
> söndag 30 maj 2010 02.21.53 skrev ?Magnus Granberg:
>> torsdag 06 maj 2010 09.24.46 skrev ?Eric Botcazou:
>> > It would be better to issue it from
>> >
>> > ?tree-nested.c:convert_tramp_reference_op so that it is attached to the
>> > ?token that causes it to be created. ?For extra points, you could even
>> > ?make
>> >
>> > ?it reference the nested function:
>> > p2.adb: In function 'P2':
>> > p2.adb:17:12: warning: trampoline generated for 'P2.F'
>> > p2.adb:26:11: warning: address taken from here
>>
>> Have updated the patch to make two warnings one for the trampoline and the
>> second one for makeing the stack executable. Did't add the reference to the
>> nested function for extra points. Could not get the testcase ignore the
>> second warning in the same line.
>>
> Have updated the patch. Can some one review it and commit it.
> If the patch is okey. Tested on x86_64-unknown-linux-gnu
>
> /Magnus
> ----
> 2010-06-18 ? ? ?Magnus Granberg ? ? ? ? <zorry@gentoo.org>, Kevin F. Quinn <kevquinn@gentoo.org>
>
> ? ? ? ? ? ? ? ?* builtins.c: ?(expand_builtin_init_trampoline): ? ? ? ?if warn_trampolines make a warning.
> ? ? ? ? ? ? ? ?* common.opt: ? Add -Wtrampolines.
> ? ? ? ? ? ? ? ?* varasm.c: ? ? ? ? ? ? (file_end_indicate_exec_stack): if warn_trampolines make a warning.
>
> gcc/doc
>
> 2010-06-18 ? ? ?Magnus Granberg ? ? ? ? <zorry@gentoo.org>
>
> ? ? ? ? ? ? ? ?* invoke.texi: ?Add -Wtrampolines.
>
> gcc/testsuite/
>
> 2010-06-18 ? ? ?Magnus Granberg ? ? ? ? <zorry@gentoo.org>
>
> ? ? ? ? ? ? ? ?* gcc.dg/Wtrampolines.c: ? ? ? ?New.
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]