This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, fortran] PR44582 - gfortran generates wrong results due to wrong ABI in function with array return
- From: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- To: Tobias Burnus <burnus at net-b dot de>
- Cc: fortran at gcc dot gnu dot org, gcc-patches <gcc-patches at gcc dot gnu dot org>, burnus at gcc dot gnu dot org, yin at absoft dot com
- Date: Mon, 28 Jun 2010 20:39:07 +0200
- Subject: Re: [Patch, fortran] PR44582 - gfortran generates wrong results due to wrong ABI in function with array return
- References: <AANLkTil-gqzM_IUMoJVCsgKtV4ymWgOSotoMa39oCWFQ@mail.gmail.com> <4C28E847.2060409@net-b.de>
Dear Tobias,
Thanks for the review.
> Thanks for the patch, which is OK - except for the following nit:
>
> ! arrayfunc_assign_needs_temporary (gfc_expr * expr1, gfc_expr * expr2)
> [...]
> ? ?/* Elemental functions don't need a temporary anyway. ?*/
> ? ?if (expr2->value.function.esym != NULL
> ? ? ? ?&& expr2->value.function.esym->attr.elemental)
> ! ? ? return true;
>
> I think the comment is misleading - given the function name and the return value; can you make the comment a bit clearer?
Indeed - this is, of course, the original comment. I'll check them all :-)
Cheers
Paul