This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] mem-ref2 merge, core patch

On 06/28/2010 12:58 PM, Richard Guenther wrote: 
INDIRECT_REF is not allowed in gimple.  You can have bare decls or
MEM_REF, and both can be wrapped inside a handled_component_p chain.
(There also still exist ALIGN_INDIRECT_REF and MISALIGNED_INDIRECT_REF
created by the vectorizer - I will do followup patches to remove those
as well)

Basically MEM_REF can appear wherever an INDIRECT_REF or a decl could
previously apper.

Thanks, this should likely go in the docs.

Would it make sense to change the other INDIRECT_REF_P types into flags on
MEM_REF?


INDIRECT_REF_P will be no longer necessary on gimple after I fixed
up the vectorizer to not use ALIGN_INDIRECT_REF and
MISALIGNED_INDIRECT_REF.  Where it currently appears it is solely
because of those two (I didn't bother to change it to
tests for ALIGN_INDIRECT_REF and MISALIGNED_INDIRECT_REF excluding
INDIRECT_REF).

Then I had understood correctly, thanks. :) Any idea about the future representation of ALIGN_INDIRECT_REF and MISALIGNED_INDIRECT_REF?

Can you expand on the (several) "#if 0/FIXME" comments? 

They should have been fixed by followup patches (I just noticed them
while writing the changelog).

Yes, indeed.

Paolo

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]