This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
I've reviewed this patch:
http://gcc.gnu.org/ml/gcc-patches/2010-04/txt00090.txt
I think the general idea is good, but I'm not happy about a couple of details:
* --enable-gold=both and --enable-gold=ld are not good spellings.
We already have --with-gnu-ld and --with-ld=/some/path. Instead of --enable-gold (or --enable=gold=gold), we should add --with-gold. And, if both --with-gnu-ld and --with-gold are present, that can be equivalent to --enable-gold=both.
* The stuff where we figure out what target support gold is too much of a hack. Every time someone changes gold, we'll have to change that too. If the user says --with-gold, just believe them. For a one-tree build, gold's configure script will presumably complain.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |