This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [v3] <regex> implementation foundation, version 3
- From: "Stephen M. Webb" <stephenw dot webb at bregmasoft dot ca>
- To: Paolo Carlini <paolo dot carlini at oracle dot com>
- Cc: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: Wed, 23 Jun 2010 16:49:40 -0400
- Subject: Re: [v3] <regex> implementation foundation, version 3
- References: <201006231622.08970.stephenw.webb@bregmasoft.ca>
- References: <4C227034.9030809@oracle.com>
- Reply-to: stephen dot webb at bregmasoft dot ca
On 23/06/10 16:36, Paolo Carlini wrote:
>
> Excellent, thanks. As far as I'm concerned, I think we are *very* close
> to the point of actually committing the code. Maybe Jon has more comments.
If I get no more comments in 24 hours or so should I go ahead and commit,
then?
> Only, since we have those three static constants - belonging to a non
> template class, thus, correctly, in a *.cc file - we must actually add a
> pattern to the linker script, otherwise we could as well take the risk
> of leaving out the definitions for now. I don't have a strong opinion,
> if the code works anyway (ie, doesn't take the address), and we are not
> exposed to the user... The problem with new exports is that you cannot
> go back, if you make a mistake... Whatever is ok with Jon is ok with me.
The linker script change is included in the patch.
If constexpr get finished soon I could replace those three constants with
something more compile-timey, but I would rather just get this checked in so
I can move on to implementing more functionality.
--
Stephen M. Webb
stephen.webb@bregmasoft.ca