This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Disallow side-effects in inline asm operands unless (a new) _ constraint modifier is used (PR middle-end/44492)


On Sun, Jun 20, 2010 at 12:29:30AM -0400, Hans-Peter Nilsson wrote:
> On Fri, 11 Jun 2010, Jakub Jelinek wrote:
> > --- gcc/recog.c.jj	2010-06-10 19:32:00.000000000 +0200
> > +++ gcc/recog.c	2010-06-11 10:14:55.000000000 +0200
> > @@ -1629,6 +1632,12 @@ asm_operand_ok (rtx op, const char *cons
> >  	case '?':
> >  	  break;
> >
> > +	case '_':
> > +#ifdef AUTO_INC_DEC
> > +	  incdec_ok = true;
> 
> ...please, also set incdec_ok = 1 for '<' and '>'.

Yeah, I can do that.

> (FWIW, I don't mind if you drop that new '_', it just looks
> weird and wasting one good letter.)

_ isn't redundant, < and > require PRE/POST_DEC/INC,
while _ allows it but doesn't require (and, allows also PRE/POST_MODIFY).

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]