This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Vector shifting patch

From: Andrew Pinski <pinskia at gmail dot com>
To: Artem Shinkarov <artyom dot shinkaroff at gmail dot com>
Cc: Richard Guenther <richard dot guenther at gmail dot com>, gcc-patches at gcc dot gnu dot org
Date: Fri, 18 Jun 2010 11:26:51 -0700
Subject: Re: Vector shifting patch
References: <AANLkTimPWUfC6QCzPwvjGNVKDk5mZYllxNpuX2iwF6aC@mail.gmail.com> <AANLkTimj-zZQTyTRW3nrCpEX5dA2rCFo-wbQs5yWwRn0@mail.gmail.com> <AANLkTinJ0_zBu9g_qAv5G0dXAH2GYaarMHnp2YzjmyCe@mail.gmail.com> <AANLkTil_5aYZQqs8JUuWc7FJJtiN9ZAFCvEZXEpddE2E@mail.gmail.com>

On Fri, Jun 18, 2010 at 5:32 AM, Artem Shinkarov
<artyom.shinkaroff@gmail.com> wrote:
> Thank you everyone for comments. Here is a new version of the patch
> which considers all the comments.

Hmm, Maybe I am missing something but I don't see a test that tests
what happens when one of the side of the shifters is an undefined
variable.  That test should be there as you changed
build_vector_from_val to fix that.

Thanks,
Andrew Pinski

Follow-Ups:
- Re: Vector shifting patch
  - From: Artem Shinkarov

References:
- Vector shifting patch
  - From: Artem Shinkarov
- Re: Vector shifting patch
  - From: Andrew Pinski
- Re: Vector shifting patch
  - From: Richard Guenther
- Re: Vector shifting patch
  - From: Artem Shinkarov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]