Re: Followup for reg_equiv_invariant patch: Fix PR39871

[Paolo Bonzini <bonzini at gnu dot org>]

My reload-fu is approximately zero, but...

On 06/15/2010 12:44 AM, Bernd Schmidt wrote:
> +	  /* If flag_pic and we have constant, verify it's legitimate.  */
> +	  if (!CONSTANT_P (x)
> +	      || !flag_pic
> +	      || LEGITIMATE_PIC_OPERAND_P (x))

This comment is not adding anything to the if condition, and maybe could 
be replaced by the comment inside the braces.

>   	    {
>   	      /* It can happen that a REG_EQUIV note contains a MEM
>   		 that is not a legitimate memory operand.  As later
> Index: ira.c
> ===================================================================
> --- ira.c	(revision 160663)
> +++ ira.c	(working copy)
> @@ -1586,12 +1586,12 @@ find_reg_equiv_invariant_const (void)
>
>   	  x = XEXP (note, 0);
>
> -	  if (! function_invariant_p (x)
> +	  if (! CONSTANT_P (x)
>   	      || ! flag_pic
>   	      /* A function invariant is often CONSTANT_P but may
>   		 include a register.  We promise to only pass CONSTANT_P
>   		 objects to LEGITIMATE_PIC_OPERAND_P.  */
> -	      || (CONSTANT_P (x)&&  LEGITIMATE_PIC_OPERAND_P (x)))
> +	      || LEGITIMATE_PIC_OPERAND_P (x))

... and this comment becomes out-of-date as there's no reference anymore 
to function_invariant_p in the code.

Paolo