This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] PR44185 Fix new prefetch test failures - second
- From: Zdenek Dvorak <rakdver at kam dot mff dot cuni dot cz>
- To: "Fang, Changpeng" <Changpeng dot Fang at amd dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "sebpop at gmail dot com" <sebpop at gmail dot com>
- Date: Wed, 9 Jun 2010 09:14:35 +0200
- Subject: Re: [patch] PR44185 Fix new prefetch test failures - second
- References: <D4C76825A6780047854A11E93CDE84D02F7721@SAUSEXMBP01.amd.com>
Hi,
> Attached is the patch to fix PR 44185: new prefetch failures. After the previous fix
> of gcc.dg/tree-ssa/prefetch-c, new failure occurs because the number of non-temporal
> stores is different in the assembler and .optimized files for different architectures. The
> reason is that the unroll_factor is different (and this is why in the original test case the unroll
> factor is limited to 1).
>
> In this patch, we don't count the exact number of non-temporal stores in the assembler and
> .optimized files. Instead, we just scan for the existence.
>
> Is it OK for the trunk?
yes, overall; but, with this change, we would not recognize if some change
breaks the optimization for just one of the loops. I guess the test needs to
be split to several testcases, one for each loop,
Zdenek