Re: [Graphite] Fix type problems in loop ivs.

[NightStrike <nightstrike at gmail dot com>]

On Mon, Jun 7, 2010 at 12:59 PM, Sebastian Pop <sebpop@gmail.com> wrote:
> On Mon, Jun 7, 2010 at 11:36, NightStrike <nightstrike@gmail.com> wrote:
>> On Wed, Jun 2, 2010 at 5:03 AM, Richard Guenther
>> <richard.guenther@gmail.com> wrote:
>>> On Wed, Jun 2, 2010 at 1:09 AM, Sebastian Pop <sebpop@gmail.com> wrote:
>>>> On Thu, Mar 11, 2010 at 09:16, Richard Guenther
>>>> <richard.guenther@gmail.com> wrote:
>>>>> On Thu, Mar 11, 2010 at 2:54 PM, Sebastian Pop <sebpop@gmail.com> wrote:
>>>>>> On Thu, Mar 11, 2010 at 04:48, Richard Guenther
>>>>>> <richard.guenther@gmail.com> wrote:
>>>>>>> Java indeed fails to initialize most of the common trees.
>>>>>>> I suggest to use ssizetype if long_long_type_node is NULL.
>>>>>>
>>>>>> Here is the fix. ?Does this look good?
>>>>>
>>>>> Hm. ?I don't like the #define. ?And Java doesn't initialize
>>>>> long_integer_type_node either, so I think the patch won't fix
>>>>> the bootstrap issue. ?Basically the C kind types are not
>>>>> really supposed to be used in the middle-end.
>>>>>
>>>>> What you probably want is to use
>>>>> smallest_mode_for_size (type_precision + 1, MODE_INT)
>>>>> and fail if that returns BLKmode (ugh, it doesn't ...).
>>>>> From the modes precision then build a type using
>>>>> build_nonstandard_integer_type. And possibly you
>>>>> want to restrict yourself to maximum BITS_PER_WORD
>>>>> size to avoid long long or TImode arithmetic.
>>>>>
>>>>
>>>> Sorry for having neglected this issue so long.
>>>> Here is the patch that fixes this induction variable type computation.
>>>> Ok for trunk after the automatic tests in the graphite branch?
>>>
>>> Ok.
>>>
>>> Thanks,
>>> Richard.
>>>
>>>> Thanks,
>>>> Sebastian
>>>>
>>>
>>
>> Ping.. was this committed?
>>
>
> Yes, this is committed as rev.160165
>
> Sebastian
>

Thanks!