This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR other/44286, with mips, sparc, C++, Fortran, gcov, frontend bits
- From: Eric Botcazou <ebotcazou at adacore dot com>
- To: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 7 Jun 2010 18:56:07 +0200
- Subject: Re: [PATCH] PR other/44286, with mips, sparc, C++, Fortran, gcov, frontend bits
- References: <20100531053427.GA8140@gmx.de>
> Bootstrapped x86_64-unknown-linux-gnu, regtest is running. I still need
> to test the mips and sparc changes.
>
> Only question I have is whether an ATTRIBUTE_SENTINEL_N(N) is preferable
> to ATTRIBUTE_SENTINEL_1. sentinel and sentinel(N) were introduced in
> the same GCC version AFAICS.
>
> There are a few more functions which use an integer zero sentinel, but
> only where all vararg arguments are integers, so it doesn't make sense
> to change that just so the attribute applies.
>
> OK to commit if no regressions show up?
The SPARC bits are OK if cc1 can still be built.
--
Eric Botcazou