This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Vector indexing patch
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Artem Shinkarov <artyom dot shinkaroff at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org, gcc at gcc dot gnu dot org, Richard Guenther <richard dot guenther at gmail dot com>
- Date: Fri, 4 Jun 2010 16:38:08 +0000 (UTC)
- Subject: Re: Vector indexing patch
- References: <AANLkTilHOUeQuit51D2jgJEqkmy_BHC4KvNx-rWn7oKa@mail.gmail.com>
On Tue, 1 Jun 2010, Artem Shinkarov wrote:
> This is a reworked patch of Andrew Pinski "Subscripting on vector
> types" in terms of GSoC 2010 [Artjoms Sinkarovs].
We can't consider it without a copyright assignment.
> The documentation was not changed. May be there could be some more
> ideas to implement.
The original patch had documentation. You should not make patches worse
in the course of reworking or updating them; documentation is required for
all patches with user-visible features. The original also had ChangeLog
entries following the usual conventions; please make sure to follow the
style of existing entries.
Since I previously approved the C changes in
<http://gcc.gnu.org/ml/gcc-patches/2009-10/msg00562.html>, and do not wish
to duplicate review effort, I am not inclined to review any reworked patch
without adequate explanation of what was changed from the approved version
and why it needed to be changed. The initial basis should be to make only
those changes to the approved patch that are strictly necessary to update
it to newer sources or to fix bugs, so that only those clearly identified
changes, and any parts not previously reviewed, need to be reviewed this
time.
--
Joseph S. Myers
joseph@codesourcery.com