This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: backport r151691 and r151729 to gcc-4.4 branch


On Thu, Jun 03, 2010 at 01:04:20AM +0930, Alan Modra wrote:
> Forget the patch.  I just realized why I was seeing the -Os failures.
> I'd fixed the obvious error in no_global_regs_above in my local 4.4
> tree, which allowed -Os to use the buggy out-of-line save and restore
> code.

Yeah, if the no_global_regs_above bug stays, then the patch isn't needed.

For 4.4 branch it would perhaps be better to just
return false;
in no_global_regs_above immediately, to avoid undefined behavior and
possible crashes.  The 4.4 code will work properly only if
no_global_regs_above is always false...

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]