This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Fix PR44363: gcc fails with ICE when compiling ffmpeg
On Tue, 1 Jun 2010, Sebastian Pop wrote:
> On Tue, Jun 1, 2010 at 13:48, Jakub Jelinek <jakub@redhat.com> wrote:
> > On Tue, Jun 01, 2010 at 01:17:55PM -0500, Sebastian Pop wrote:
> >> the attached patch should fix the PR44363 by failing the if-conversion
> >> analysis in a more safe way, returning "analysis failed" instead of calling
> >> the ICE-ing gcc_unreachable. ?I will regstrap this patch if there are no
> >> concerns about this. ?Ok for trunk after regstrap passes?
> >
> > I see that predicate_bbs resets all debug stmts right away.
> > Isn't that premature to do it when just checking whether the optimization
> > cab be performed or not? ?There are several cases after that reset which
> > can decide the optimization is not possible, and then we just needlessly
> > lost debug info quality.
>
> Fixed by reseting the debug info only from the code generation part, not
> from the analysis. Ok for trunk after regstrap?
Ok.
Thanks,
Richard.