Re: [patch][ada] Clean up middle-end includes from the ada front end

[Steven Bosscher <stevenb dot gcc at gmail dot com>]

On Tue, May 25, 2010 at 9:34 PM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>> ? ? ? * gcc-interface/utils.c: Do not include function.h, pointer-set.h,
>> ? ? ? and gimple.h. ?Explain why rtl.h has to be included.
>> ? ? ? (handle_vector_size_attribute): Call reconstruct_complex_type directly.
>> ? ? ? * gcc-interface/targtyps.c: Do not include tm_p.h
>> ? ? ? * gcc-interface/utils2.c: Do not include flags.h.
>> ? ? ? * gcc-interface/trans.c: Do not include expr.h. ?Include rtl.h instead,
>> ? ? ? and explain why it has to be included.
>> ? ? ? * gcc-interface/misc.c: Do not include expr.h, libfuncs.h, cgraph.h,
>> ? ? ? and optabs.h.
>> ? ? ? Include function.h and explain why. ?Explain why except.h is included.
>> ? ? ? (enumerate_modes): Remove unused function.
>> ? ? ? * gcc-interface/gigi.h (enumerate_modes): Remove prototype.
>> ? ? ? * gcc-interface/Make-lang.in: Update dependencies.
>
> OK, but see below.

Thanks.

>> Index: gcc-interface/trans.c
>> ===================================================================
>> --- gcc-interface/trans.c ? ? (revision 159837)
>> +++ gcc-interface/trans.c ? ? (working copy)
>> @@ -29,7 +29,9 @@
>> ?#include "tm.h"
>> ?#include "tree.h"
>> ?#include "flags.h"
>> -#include "expr.h"
>> +#include "rtl.h" ? ? /* FIXME: For set_stack_check_libfunc and
>> + ? ? ? ? ? ? ? ? ? ? ? ?gen_rtx_SYMBOL_REF -- here is a front end
>> + ? ? ? ? ? ? ? ? ? ? ? ?still trying to generate RTL! ?*/
>
> Yeah, this is the old stack checking kludge. ?If you really want to get rid of
> RTL here, you can probably move the set_stack_check_libfunc thing to the Tree
> level, only the symbol name really matters in the end.

I really want to get rid of RTL here :-)  This is the only place I've
found so far in non-target specific front-end code that still
generates RTL.

I was thinking about just passing the symbol name (as a string) to
set_stack_check_libfunc and let set_stack_check_libfunc do the
get_rtx_SYMBOL_REF call. Would that also be OK for you?

Ciao!
Steven