Re: [patch, fortran] PR31346 - improve whole-file checking (2nd update)

[Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>]

Daniel,

This is OK for trunk and for 4.5, after a week or so.

Thanks for the patch!  Next time, reserve testcase numbers in advance..... :-)

Paul

On Mon, May 24, 2010 at 11:59 PM, Daniel Franke <franke.daniel@gmail.com> wrote:
> On Monday 24 May 2010 20:38:06 Daniel Franke wrote:
>> On Monday 24 May 2010 17:40:00 Daniel Franke wrote:
>> > if no explicit interface is given, a called procedure must not have dummy
>> > arguments with assumed-shape. Attached patch adds a whole-file check for
>> > that.
>>
>> While at it, verify that return type, kind and string lengths match.
>
> Second update: optional arguments require an explicit interface as well.
>
>
> gcc/fortran/:
> 2010-05-24 ?Daniel Franke ?<franke.daniel@gmail.com>
>
> ? ? ? ?PR fortran/30668
> ? ? ? ?PR fortran/31346
> ? ? ? ?* resolve.c (resolve_global_procedure): Add check for global
> ? ? ? ?procedures with implicit interfaces and assumed-shape or optional
> ? ? ? ?dummy arguments. Verify that function return type, kind and string
> ? ? ? ?lengths match.
>
> gcc/testsuite/:
> 2010-05-24 ?Daniel Franke ?<franke.daniel@gmail.com>
>
> ? ? ? ?PR fortran/30668
> ? ? ? ?PR fortran/31346
> ? ? ? ?* gfortran.dg/pr40999.f: Fix function type.
> ? ? ? ?* gfortran.dg/whole_file_5.f90: Likewise.
> ? ? ? ?* gfortran.dg/whole_file_6.f90: Likewise.
> ? ? ? ?* gfortran.dg/whole_file_16.f90: New.
> ? ? ? ?* gfortran.dg/whole_file_17.f90: New.
> ? ? ? ?* gfortran.dg/whole_file_18.f90: New.
>
>
> Once more regression tested on i686-pc-linux-gnu.
> Ok for trunk?
>
> ? ? ? ?Daniel
>



-- 
The knack of flying is learning how to throw yourself at the ground and miss.
       --Hitchhikers Guide to the Galaxy