This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH,c++] make rtti.c use build_constructor


Nathan Froyd wrote:

> -Nathan
> 
> 	* rtti.c (tinfo_base_init): Use build_constructor instead of
> 	build_constructor_from_list.  Don't cons a tree node for
> 	returning.
> 	(generic_initializer): Use build_constructor_single instead of
> 	build_constructor_from_list.
> 	(ptr_initializer): Use build_constructor instead of
> 	build_constructor_from_list
> 	(ptm_initializer): Likewise.
> 	(class_initializer): Likewise.  Take varargs instead of TRAIL.
> 	(get_pseudo_ti_init): Adjust calls to class_initializer.  Use
> 	build_constructor instead of build_constructor_from_list.

OK.

Once you get this batch in, I suggest taking a couple of days pause to
see what, if anything, is broken.  This stuff with vtables and typeinfo
will not be fun to debug if there are problems, so you probably don't
want to pile on too much more complexity.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]