This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Unreviewed^2 testsuite, build, c++/lto patches
- From: Paolo Bonzini <bonzini at gnu dot org>
- To: Rainer Orth <ro at cebitec dot uni-bielefeld dot de>
- Cc: gcc-patches at gcc dot gnu dot org, Janis Johnson <janis dot marie dot johnson at gmail dot com>, Richard Henderson <rth at redhat dot com>, Jason Merrill <jason at redhat dot com>, Mark Mitchell <mark at codesourcery dot com>, Diego Novillo <dnovillo at google dot com>
- Date: Fri, 21 May 2010 18:02:36 +0200
- Subject: Re: Unreviewed^2 testsuite, build, c++/lto patches
- References: <yddfx1ls69l.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
On Fri, May 21, 2010 at 16:01, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
> A couple of patches have remained unreviewed for some time, some of them
> despite one or more reminders:
>
> ? ? ? ?[testsuite] Skip gcc.c-torture/execute/960321-1.c on Solaris 2/x64 with Sun as
> ? ? ? ?http://gcc.gnu.org/ml/gcc-patches/2010-05/msg00205.html
>
> Needs a testsuite maintainer ;-)
Who doesn't. :)
> ? ? ? ?[build] Avoid use of unportable grep -q
> ? ? ? ?http://gcc.gnu.org/ml/gcc-patches/2010-05/msg00656.html
See Jason Merrill's message in
http://gcc.gnu.org/ml/gcc-patches/2010-05/msg01598.html
> ? ? ? ?[build, c++, lto] Support COMDAT group with Sun as (PR target/40483)
> ? ? ? ?http://gcc.gnu.org/ml/gcc-patches/2010-05/msg01365.html
>
> Although the patch isn't completely ready (and needs Solaris 2/SPARC
> testing), it would be good to get comments from C++ and/or LTO
> maintainers on the chosen approach.
Build parts looks sane, I think most C++ and LTO reviewers will be
able to approve them too.
Paolo