This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, C] PR18249

On Thu, 20 May 2010, Shujing Zhao wrote:

> asprintf(&buf, G_("expected '%s'"), token_desc);

I have not reviewed this patch.  But it would but nice if someone could 
review the addition of xasprintf to libiberty 
<http://gcc.gnu.org/ml/gcc-patches/2009-11/msg01448.html> 
<http://gcc.gnu.org/ml/gcc-patches/2009-11/msg01449.html>, so we can avoid 
the proliferation of unchecked asprintf calls.

(Also note coding style: space between "asprintf" and "(".)

-- 
Joseph S. Myers
joseph@codesourcery.com
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]