This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [i386] fix ms_abi -> sysv_abi float passing, try 2
On Thu, May 20, 2010 at 12:24 PM, Kai Tietz <ktietz70@googlemail.com> wrote:
>> For gcc/ChangeLog:
>>
>> ? ? ? ?PR target/43869
>> ? ? ? ?* config/i386/i386.c: Make sure that the correct regparm is passed.
>>
>> For gcc/testsuite/ChangeLog:
>>
>> ? ? ? ?PR target/43869
>> ? ? ? ?* gcc.c-target/pr43869.c: New test.
>>
>> ---
>> SSE_REGPARM_MAX will not be the correct amount of registers on 64-bits here,
>> since it's a macro that expands depending on current function to
>> X86_64_SSE_REGPARM_MAX or X86_64_MS_SSE_REGPARM_MAX. In a few other
>> functions switching between the 2 does not make sense, since it's always a
>> fixed sysv abi there, ms_abi has its own functions, so remove the toggling.
>>
>> Regarding copyright assignment, codeweavers should already have one on file
>> :)
>>
>> Can this be backported to the stable branches as well?
>>
>>
>
> From my side this patch looks fine. I've CC'ed Uros as i386
> maintainer, as he has to make the approval. IMHO a back-merge to 4.5
> branch makes sense.
The testcase was not attached, please report your patch with the test.
Thanks,
Uros.