This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix DW_OP_bit_piece on big-endian

From: Jason Merrill <jason at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org, Tom Tromey <tromey at redhat dot com>, Roland McGrath <roland at redhat dot com>
Date: Wed, 19 May 2010 14:34:56 -0400
Subject: Re: [PATCH] Fix DW_OP_bit_piece on big-endian
References: <20100518153532.GH10293@tyan-ft48-01.lab.bos.redhat.com>

On 05/18/2010 11:35 AM, Jakub Jelinek wrote:

+	      && ((unsigned HOST_WIDE_INT) INTVAL (MEM_SIZE (varloc))
+		  * BITS_PER_UNIT) != bitsize)
+	    {
+	      unsigned HOST_WIDE_INT memsize
+		= INTVAL (MEM_SIZE (varloc)) * BITS_PER_UNIT;

I'd prefer to compute this once, before the if. OK with that change.

Jason

References:
- [PATCH] Fix DW_OP_bit_piece on big-endian
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]