Re: [build, libffi] Support Solaris 8/9 x86 with Sun as

[Paolo Bonzini <bonzini at gnu dot org>]

> > To be honest, I've no idea why the test doesn't simply check the
> > compiler exit code, but didn't want to change this at this point.

Because it was a warning.  If you prefer you can check for the warning
as is (without additional wordings), and for the exit code as well.

> Will do next time, but could we do without now? ?The only part needing
> x86 maintainer approval is the config/i386/32/sfp-machine.h change.
>
> The libffi stuff is pretty well localized

Please commit this separately though, possibly resubmitting along the
above lines if you prefer that.

> , the .quad stuff only affects
> Solaris, so I can approve it myself, and even the .hidden disabling is
> only done for i?86-*-solaris2*, so given Paolo's past comments, I can
> approve that myself, too.

True (but thanks for asking for a second opinion anyway).

Paolo