This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Request for code review - (ZEE patch : Redundant Zero extension elimination)
- From: Sriraman Tallam <tmsriram at google dot com>
- To: Bernd Schmidt <bernds at codesourcery dot com>
- Cc: Andrew Pinski <pinskia at gmail dot com>, Diego Novillo <dnovillo at google dot com>, Paolo Bonzini <bonzini at gnu dot org>, Ian Lance Taylor <iant at google dot com>, Richard Guenther <richard dot guenther at gmail dot com>, rth at redhat dot com, Jie Zhang <jie dot zhang at analog dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <jh at suse dot cz>, Uros Bizjak <ubizjak at gmail dot com>
- Date: Mon, 17 May 2010 09:48:42 -0700
- Subject: Re: Request for code review - (ZEE patch : Redundant Zero extension elimination)
- References: <4B4E1F14.7020508@gmail.com> <r2yf865508f1005010030zc7b54ea4h34056d5bd413eaf1@mail.gmail.com> <AANLkTimKF7br-0IkdpMHIteDMAcOf5uhcLjOuAL4QSab@mail.gmail.com> <4BE44197.20101@google.com> <AANLkTimuYxeK0WKetLsIDAB6VxRAG334IKoRPSeJBXw9@mail.gmail.com> <AANLkTikgEEXZDHFTTW4CDisYD1MAeeqBBky1_-G0RK1l@mail.gmail.com> <AANLkTimF_8Auv1CqQa57Jd2SgQIPcN3PCwIva5jU9pHm@mail.gmail.com> <AANLkTil_68imB7825T_5Auu-221nmWvIYqN5T9YSNdzJ@mail.gmail.com> <AANLkTik3WwhKzaJFT7ei6vw5i_1hMEXqMW19K4O3Dy8J@mail.gmail.com> <4BF10591.4020207@codesourcery.com>
On Mon, May 17, 2010 at 2:00 AM, Bernd Schmidt <bernds@codesourcery.com> wrote:
> On 05/12/2010 11:18 PM, Sriraman Tallam wrote:
>>> I know this most likely has been hashed before but why is this pass
>>> have SImode and DImode hardcoded?
>>> Can't you use the modes and then try a wider mode? ?Or does that need
>>> a total rewrite of the pass?
>>
>> Yes, that requires modifying a large portion.
>
> I agree with Andrew. ?Hardcoding the modes the way it's done in this
> pass really isn't up to the standards we should expect from new passes.
> ?Please work on fixing this.
Will do. However, when I wrote this pass I had x86_64 in mind which
does the optimization only for that specific mode.
Since I have already submitted the patch, I will make a new patch for the fix.
>
>
> Bernd
>