This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[PATCH] Temporary fix for PR bootstrap/44146
- From: Jack Howarth <howarth at bromo dot med dot uc dot edu>
- To: gcc-patches at gcc dot gnu dot org
- Cc: hubicka at ucw dot cz, mikestump at comcast dot net
- Date: Sat, 15 May 2010 16:18:53 -0400
- Subject: [PATCH] Temporary fix for PR bootstrap/44146
Currently the bootstrap on *-apple-darwin* is failing periodically
with changes in svn since the introduction of...
r159371 | hubicka | 2010-05-13 13:47:48 -0400 (Thu, 13 May 2010) | 3 lines
* varpool.c (decide_is_variable_needed): Drop code checking
TREE_SYMBOL_REFERENCED.
Until the exact cause of these bootstrap failures is found and
solved, darwin should revert to the previous behavior to allow
for general testing of unpatched gcc trunk. Regression tested at
r159434 on x86_64-apple-darwin10. Okay for gcc trunk?
Jack
2010-05-15 Jack Howarth <howarth@bromo.med.uc.edu>
PR bootstrap/44146
* varpool.c (decide_is_variable_needed): Restore code checking
TREE_SYMBOL_REFERENCED for darwin.
Index: gcc/varpool.c
===================================================================
--- gcc/varpool.c (revision 159434)
+++ gcc/varpool.c (working copy)
@@ -321,6 +321,13 @@
|| node->force_output)
return true;
+ /* ??? If the assembler name is set by hand, it is possible to assemble
+ the name later after finalizing the function and the fact is noticed
+ in assemble_name then. This is arguably a bug. */
+ if (TARGET_MACHO && DECL_ASSEMBLER_NAME_SET_P (decl)
+ && TREE_SYMBOL_REFERENCED (DECL_ASSEMBLER_NAME (decl)))
+ return true;
+
/* Externally visible variables must be output. The exception is
COMDAT variables that must be output only when they are needed. */
if (TREE_PUBLIC (decl)