This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, fortran] Fix PR34505 - improved checking for [D]FLOAT and SNGL


On Thursday 13 May 2010 19:06:47 Steve Kargl wrote:
> On Thu, May 13, 2010 at 06:44:28PM +0200, Daniel Franke wrote:
> > Attached patch improves the checking of [D]FLOAT and SNGL by rejecting
> > the wrong types and adding a -std= warning/error if used with other
> > kinds than the expected ones.
> > 
> > Further, I removed the individual docs of FLOAT, DFLOAT and SNGL and
> > added them as specific names to REAL instead.
> 
> Daniel,
> 
> While I believe what you have done is correct, have
> you tested this change with some of the older codes
> at netlib, e.g., blas, lapack, minpack, specfcn?
> I have a bad feeling that FLOAT, DFLOAT and SNGL
> are ripe for vendor extension abuse.

Hi Steve,

no, I didn't. And I just realized that there's still an error somewhere, 
KIND(DBLE(42)) now returns 4, not 8. Sh ... ame.

Be back later with an update.

	Daniel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]