Re: Unreviewed patches

[Paolo Bonzini <bonzini at gnu dot org>]

On 05/10/2010 01:33 PM, Rainer Orth wrote:
> > > 	[testsuite] Skip gcc.c-torture/execute/960321-1.c on Solaris 2/x64 with Sun as
> > >          http://gcc.gnu.org/ml/gcc-patches/2010-05/msg00205.html
> >
> > Don't you have to test x86_64-*-solaris2* too here, since there is this in
> > config.guess:
> >
> > i86pc:SunOS:5.*:* | i86xen:SunOS:5.*:*)
> >    ...
> >                  SUN_ARCH="x86_64"
> >    ...
> >    echo ${SUN_ARCH}-pc-solaris2`echo ${UNAME_RELEASE}|sed -e 's/[^.]*//'`
> >
> > ?
>
> No, there's no x86_64-*-solaris2* configuration in gcc, cf. PR
> bootstrap/39150.  config.guess only detects this if run with a compiler
> that produces 64-bit objects by default (e.g. CC='gcc -m64'), and
> neither gcc nor cc do.  The Solaris 10+ GCC configurations are
> multilibbed, with 32-bit as the default, thus i?86-*-solaris2*.

The testsuite can be run on an installed compiler, so there _is_ the 
possibility of running on x86_64-*-solaris2*.  For a one line change, it 
seems worthwhile to do it.

Anyway, that's just my humble opinion; I'll let Janis or whoever else 
approves the patch decides.

Paolo