This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix PR43984, PRE misses full redundancies


On Thu, May 6, 2010 at 6:56 AM, Michael Matz <matz@suse.de> wrote:
> Hi,
>
> On Wed, 5 May 2010, Richard Guenther wrote:
>
>> > Hence, I'd go with the below patch in the end. ?Nevertheless okay if
>> > regstrapping still passes?
>>
>> Ok.
>
> I've checked it in as r159106 with this additional hook to have saner
> statistics (and not have to change some PRE testcases):
>
> ? ? ? ? ?/* Queue the copy for eventual removal. ?*/
> ? ? ? ? ?VEC_safe_push (gimple, heap, to_remove, stmt);
> - ? ? ? ? pre_stats.eliminations++;
> + ? ? ? ? /* If we inserted this PHI node ourself, it's not an elimination. ?*/
> + ? ? ? ? if (bitmap_bit_p (inserted_exprs, SSA_NAME_VERSION (res)))
> + ? ? ? ? ? pre_stats.phis--;
> + ? ? ? ? else
> + ? ? ? ? ? pre_stats.eliminations++;
> ? ? ? ?}
> ? ? }
>

This caused:

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=44020


-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]