This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Emit DW_AT_identifier_case DW_ID_down_case for Fortran compilation units (PR debug/43950)
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Jason Merrill <jason at redhat dot com>, gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
- Date: Tue, 4 May 2010 16:44:47 -0700
- Subject: Re: [PATCH] Emit DW_AT_identifier_case DW_ID_down_case for Fortran compilation units (PR debug/43950)
- References: <20100430192501.GP2817@tyan-ft48-01.lab.bos.redhat.com>
On Fri, Apr 30, 2010 at 09:25:01PM +0200, Jakub Jelinek wrote:
>
> The fortran FE lowercases all identifiers (and the language is case
> insensitive), so we shouldn't use the default DW_AT_identifier_case
> DW_ID_case_sensitive for Fortran.
>
> Tested on x86_64-linux.
>
> Ok for trunk?
>
> 2010-04-30 Jakub Jelinek <jakub@redhat.com>
>
> PR debug/43950
> * dwarf2out.c (gen_compile_unit_die): Add DW_AT_identifier_case
> DW_ID_down_case for Fortran compilation units.
>
As a Fortran user and maintainer I think the patch is fine.
I, however, may not have the proper authorization to approve
the patch.
--
Steve