This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH,4.5 Regression] Re: [PATCH,PR43888] Weak symbols may bind non-locally on Windows.
- From: Kai Tietz <ktietz70 at googlemail dot com>
- To: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 3 May 2010 10:54:14 +0200
- Subject: Re: [PATCH,4.5 Regression] Re: [PATCH,PR43888] Weak symbols may bind non-locally on Windows.
- References: <4BDAF70B.6020600@gmail.com> <4BDE15CA.3000509@gmail.com>
2010/5/3 Dave Korn <dave.korn.cygwin@googlemail.com>:
> On 30/04/2010 16:28, Dave Korn wrote:
>
>> ? This fixes the following extant C and C++ failures on i686-pc-cygwin:
>>
>> -FAIL: g++.dg/eh/weak1.C execution test
>> -FAIL: gcc.dg/alias-7.c execution test
>> -FAIL: gcc.dg/tree-ssa/pr27781.c scan-tree-dump optimized "func \\(\\);"
>>
>> gcc/ChangeLog:
>>
>> ? ? ? * config/i386/winnt.c (i386_pe_binds_local_p): Handle weak decls.
>>
>> ? Bootstrapped and tested(*) on i686-pc-cygwin; I'll apply this in 24 hours if
>> nobody objects.
>
> ?Applied. ?I've now verified that this is a true regression as the testcase
> passes with 4.3.4, so can I backport it to the 4.5 branch please?
Dave,
yes, I think a back-merge of this patch is the right thing. As it is
an regression, please go a head.
Cheers,
Kai
--
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination