This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch]: Fix multilib/non-multilib build for 4.6 for *-w64-mingw32


Hello Jakub,

As I found by svn blame that you wrote those lines some time ago.
Problem is here that --disable-multilib is disregarded in Makefile.in
file in gcc/.

It checks for multilib configuration as logic

s-mlib: $(srcdir)/genmultilib Makefile
        if test @enable_multilib@ = yes \
           || test -n "$(MULTILIB_OSDIRNAMES)"; then \

which means that a target supporting MULTILIB_OSDIRNAME always get
multilib configuration, which seems for me wrong.

Shouldn't be the logic here

s-mlib: $(srcdir)/genmultilib Makefile
        if test @enable_multilib@ = yes \
           && test -n "$(MULTILIB_OSDIRNAMES)"; then \

instead?

Cheers,
Kai

PS: Prior patch drawn back.

-- 
|  (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]