Re: PATCH: PR target/43921: Bootstrap comparison fails when using -march=atom

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Wed, Apr 28, 2010 at 11:46 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Wed, Apr 28, 2010 at 11:23:09AM -0700, H.J. Lu wrote:
>
>> @@ -26765,7 +26765,7 @@ extended_reg_mentioned_1 (rtx *p, void *data ATTRIBUTE_UNUSED)
>> ?bool
>> ?x86_extended_reg_mentioned_p (rtx insn)
>> ?{
>> - ?return for_each_rtx (INSN_P (insn) ? &PATTERN (insn) : &insn,
>> + ?return for_each_rtx (NONDEBUG_INSN_P (insn) ? &PATTERN (insn) : &insn,
>> ? ? ? ? ? ? ? ? ? ? ?extended_reg_mentioned_1, NULL);
>> ?}
>
> This hunk is IMHO wrong, for NONDEBUG_INSN_P just PATTERN should be
> scanned and nothing else. ?The rest looks good to me, though you need
> someone to approve it.
>
> ? ? ? ?Jakub
>

I am testing this on Linux/x86.  OK for trunk and 4.5 if no regressions?

Thanks.


-- 
H.J.

Attachment: gcc-pr43921-2.patch
Description: Text document