This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] support for -fdump-ada-spec
- From: Manuel López-Ibáñez <lopezibanez at gmail dot com>
- To: Arnaud Charlet <charlet at adacore dot com>
- Cc: gcc-patches at gcc dot gnu dot org, joseph at codesourcery dot com, mark at codesourcery dot com
- Date: Mon, 26 Apr 2010 15:45:52 +0200
- Subject: Re: [patch] support for -fdump-ada-spec
- References: <20100426124645.GA29479@adacore.com>
On 26 April 2010 14:46, Arnaud Charlet <charlet@adacore.com> wrote:
> ? ? ? ?* diagnostic.h (decl_sloc, to_ada_name, collect_ada_nodes,
> ? ? ? ?collect_source_ref, dump_ada_specs, dump_ada_macros): Declare.
I don't want to sound picky but I disagree with polluting the
diagnostics interface further. If diagnostics.c was a stand-alone
library, these functions wouldn't be declared here. In fact, we should
start moving in the opposite direction and moving declarations out of
diagnostics.h that have nothing to do with diagnostics.c. Why these
functions cannot be declared in their own module/header file
c-ada-spec.h? why they need to be included by every user of
diagnostics.h?
Cheers,
Manuel.