This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Uniquization of constants at the Tree level
> I doubt that this will work with LTO as-is. Why can't we use
> a file-scope shared CONST_DECL instead?
tree_output_constant_def creates file-scope shared read-only VAR_DECLs. Why
would we gain by using a CONST_DECL instead? On the contrary, this may be
problematic because CONST_DECLs are replaced with their DECL_INITIAL, which
is precisely what we want to avoid here.
> Most of the fixes regarding to vector types look ok - can you
> split them out? The IN_NAMED_SECTION parts look obvious
> if split out.
OK, will do.
> Can you add a LTO testcase that has your C example in one
> file and a main() in another verifying correctness of the
> resulting initializer?
OK.
--
Eric Botcazou