This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR43839 - libjava incorrectly uses -liconv in testsuite
- From: Tom Tromey <tromey at redhat dot com>
- To: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- Cc: Jack Howarth <howarth at bromo dot med dot uc dot edu>, gcc-patches at gcc dot gnu dot org, mikestump at comcast dot net
- Date: Fri, 23 Apr 2010 14:13:54 -0600
- Subject: Re: [PATCH] Fix PR43839 - libjava incorrectly uses -liconv in testsuite
- References: <20100423022403.GA30582@bromo.med.uc.edu> <4BD1C235.5000909@gmail.com>
- Reply-to: tromey at redhat dot com
>>>>> "Dave" == Dave Korn <dave.korn.cygwin@googlemail.com> writes:
>> - lappend cxxflags -shared-libgcc -lgcj -liconv
>> + eval lappend cxxflags "-shared-libgcc -lgcj $libiconv"
Dave> ... if you don't add either the quotes or the eval, doesn't it
Dave> "just work"?
If $libiconv can be empty, then the plain form will add an empty element
to the list. The eval+quotes form won't.
% set empty ""
% lappend x a b c $empty
a b c {}
% eval lappend y "a b c $empty"
a b c
Tom