This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR43839 - libjava incorrectly uses -liconv in testsuite
- From: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- To: Jack Howarth <howarth at bromo dot med dot uc dot edu>
- Cc: gcc-patches at gcc dot gnu dot org, mikestump at comcast dot net, tromey at redhat dot com
- Date: Fri, 23 Apr 2010 16:52:21 +0100
- Subject: Re: [PATCH] Fix PR43839 - libjava incorrectly uses -liconv in testsuite
- References: <20100423022403.GA30582@bromo.med.uc.edu>
On 23/04/2010 03:24, Jack Howarth wrote:
> The following patch eliminates the failure of the PR16923 libjava
> testcase on *-*-darwin* when -with-libiconv-prefix is used to provide
> an alternative location for libiconv. Tested on x86_64-apple-darwin10.
> Okay for gcc trunk and gcc 4.5.1?
It's not my area, but as we discussed on the main list:
> - lappend cxxflags -shared-libgcc -lgcj -liconv
> + eval lappend cxxflags "-shared-libgcc -lgcj $libiconv"
... if you don't add either the quotes or the eval, doesn't it "just work"?
cheers,
DaveK