This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: Consistently generate widening multiplies
On Wed, Apr 21, 2010 at 7:41 PM, Bernd Schmidt <bernds@codesourcery.com> wrote:
> On 04/21/2010 07:39 PM, Bernd Schmidt wrote:
>> Here's a new version of the patch. ?Other than addressing your review
>> comments (ignoring the naming of the pass for now since as you said we
>> can rename it anytime), I also had to fix expand_debug_expr not to
>> generate invalid RTL, and I've decided to add a check for optab
>> availability to the pass - this seems to be better for code generation
>> on the whole.
>
> Huh. ?I seem to have picked the wrong one to work from, this one still
> has direct tests for CONVERT_EXPR and NOP_EXPR rather than
> CONVERT_EXPR_CODE_P. ?I'm fixing this locally, let me know if you want
> to see a new patch.
+ if (rhs1_stmt == NULL && rhs2_stmt == NULL)
+ continue;
please move this check first, it look cheapest and
will likely trigger most often.
The patch is ok with that change and the CONVERT_EXPR_CODE_P thing.
Thanks,
Richard.
>
> Bernd
>