This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Emit DW_AT_enum_class attribute for C++0x scoped enums
On Fri, Apr 16, 2010 at 06:58:29PM -0400, Jason Merrill wrote:
> On 04/16/2010 05:37 PM, Richard Guenther wrote:
> >On Fri, Apr 16, 2010 at 7:24 PM, Jason Merrill<jason@redhat.com> wrote:
> >>I thought the plan was to generate the debug info ahead of time and then
> >>include it in the LTO output.
> >
> >That was the plan.
> >
> >>The patch looks fine to me.
> >
> >But it doesn't bring us anywhere closer to reasonable debug information
> >for C++ with LTO.
>
> But it doesn't take us any farther, either; if we generate the debug
> info in advance it doesn't matter what mechanism is used.
>
> That said, the patch to use the static bit on ENUMERAL_TYPE seems
> simple enough to go with that one. I'd name the macro something
> with SCOPED rather than CLASS, though; 'enum class' is just the C++
> syntax for a more general concept.
I've used ENUM_CLASS_P for the bit macro, because DW_AT_enum_class
is the DWARF 4 attribute name and because SCOPED_ENUM_P is already used
as macro in cp-tree.h. I initially thought about moving the 3
macros (SCOPED_ENUM_P, UNSCOPED_ENUM_P and SET_SCOPED_ENUM_P) all to
tree.h, but I believe e.g. the large, clearly C++ specific, comments
probably don't belong to generic tree.h. The bit macro
in tree.h probably could be ENUM_IS_SCOPED_P or something similar.
Jakub