This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Move double-int stuff from fold-const to double-int
On Fri, Apr 16, 2010 at 11:03:20PM +0200, Richard Guenther wrote:
> On Fri, Apr 16, 2010 at 6:45 PM, Michael Meissner
> <meissner@linux.vnet.ibm.com> wrote:
> > On Thu, Apr 15, 2010 at 01:17:44PM +0200, Richard Guenther wrote:
> >>
> >> This is a patch I have probably re-done three or four times already
> >> but never sought to commit it. ?Well, it's a cleanup to move things
> >> to where they (should) belong.
> >>
> >> Now, svn sucks, so this will break svn blame unless you go hunting
> >> through the revs. ?So if people think moving things is bad I'll
> >> just throw away the patch again.
> >>
> >> Comments?
> >
> > I like it, but if we are moving the functions, it might be a good time to
> > change the name. ?To me, double by itself means double precision floating
> > point. ?If the double were double_int, dblint, or something similar, then it
> > would be more meaningful.
>
> Maybe, I think that's less of a priority to me though (and a way more
> intrusive change). I hope to instead cleanup the implementation
> side now and remove some redundancies there.
Yep, I agree it is intrusive, and I agree it is lower in priority....
--
Michael Meissner, IBM
4 Technology Place Drive, MS 2203A, Westford, MA, 01886, USA
meissner@linux.vnet.ibm.com