This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH,4.6/4.5.1,PR42776] Implement LTO for Windows (PE-COFF) targets.


Hi Dave,

First: Wow.

Then a request:

> gcc/ChangeLog
> ? ? ? ?* collect2.c (is_elf): Rename from this ...
> ? ? ? ?(is_elf_or_coff): ... to this, and recognize and allow i386 COFF
> ? ? ? ? object files in addition to ELF-formatted ones.
> ? ? ? ?(scan_prog_file): Caller updated. ?Also allow for LTO info marker
> ? ? ? ?symbol to be prefixed or not by an extra underscore.
>
> ? ? ? ?* lto.h (lto_elf_file_open): Rename prototype from this ...
> ? ? ? ?(lto_obj_file_open): ... to this.
> ? ? ? ?(lto_elf_file_close): Likewise ...
> ? ? ? ?(lto_obj_file_close): ... and likewise.
> ? ? ? ?(lto_elf_build_section_table): Likewise ...
> ? ? ? ?(lto_obj_build_section_table): ... and likewise.
> ? ? ? ?(lto_elf_begin_section): Likewise ...
> ? ? ? ?(lto_obj_begin_section): ... and likewise.
> ? ? ? ?(lto_elf_append_data): Likewise ...
> ? ? ? ?(lto_obj_append_data): ... and likewise.
> ? ? ? ?(lto_elf_end_section): Likewise ...
> ? ? ? ?(lto_obj_end_section): ... and likewise.
> ? ? ? ?* lto.c (lto_file_read): Update references to the above.
> ? ? ? ?(lto_wpa_write_files): Likewise.
> ? ? ? ?(lto_read_all_file_options): Likewise.
> ? ? ? ?(read_cgraph_and_symbols): Likewise.
> ? ? ? ?* gcc/lto/lto-lang.c (LANG_HOOKS_BEGIN_SECTION): Likewise.
> ? ? ? ?(LANG_HOOKS_APPEND_DATA): Likewise.
> ? ? ? ?(LANG_HOOKS_END_SECTION): Likewise.
> ? ? ? ?* lto-elf.c (lto_elf_file_open): Rename from this ...
> ? ? ? ?(lto_obj_file_open): ... to this, updating any references.
> ? ? ? ?(lto_elf_file_close): Likewise ...
> ? ? ? ?(lto_obj_file_close): ... and likewise.
> ? ? ? ?(lto_elf_build_section_table): Likewise ...
> ? ? ? ?(lto_obj_build_section_table): ... and likewise.
> ? ? ? ?(lto_elf_begin_section): Likewise ...
> ? ? ? ?(lto_obj_begin_section): ... and likewise.
> ? ? ? ?(lto_elf_append_data): Likewise ...
> ? ? ? ?(lto_obj_append_data): ... and likewise.
> ? ? ? ?(lto_elf_end_section): Likewise ...
> ? ? ? ?(lto_obj_end_section): ... and likewise.

Could you commit these bits separately? It will make it easier, later
on, to see what changes you had to make to port LTO to COFF from these
de-ELF-ization renamings.

Ciao!
Steven


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]