This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Add double_int_not, double_int_lshift and double_int_rshift functions.

From: Eric Botcazou <ebotcazou at adacore dot com>
To: Richard Guenther <richard dot guenther at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org, Anatoly Sokolov <aesok at post dot ru>
Date: Mon, 12 Apr 2010 12:30:33 +0200
Subject: Re: Add double_int_not, double_int_lshift and double_int_rshift functions.
References: <1993260412.20100410030416@post.ru> <h2t84fc9c001004120236k1d3c7edbq6a502adbfa07c617@mail.gmail.com>

> Thanks for these cleanups.  Can you move both tree_to_double_int
> and double_int_negative_p to double-int.h from double-int.c as
> a followup?  A patch to do so is pre-approved.

And there is a pasto in the description of double_int_rshift, rshift_double 
explicitly requires COUNT to be positive.  It would also have been better to 
keep the same prototype ('int' for arith) or change everything to 'bool'.

"Shift the A left"

"Shift A left" would be better.


"Shift the A rigth"

"Shift A right"

-- 
Eric Botcazou

References:
- Add double_int_not, double_int_lshift and double_int_rshift functions.
  - From: Anatoly Sokolov
- Re: Add double_int_not, double_int_lshift and double_int_rshift functions.
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]