This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch V3] Fix bootstrap/43684 (was) Re: [Patch] Remove "set but unused" vars from rs6000.c.

From: Jakub Jelinek <jakub at redhat dot com>
To: Diego Novillo <dnovillo at google dot com>
Cc: IainS <developer at sandoe-acoustics dot co dot uk>, Jakub Jelinek <jakub at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Fortran List <fortran at gcc dot gnu dot org>, David Edelsohn <dje dot gcc at gmail dot com>, Mike Stump <mikestump at comcast dot net>
Date: Fri, 9 Apr 2010 15:29:58 +0200
Subject: Re: [Patch V3] Fix bootstrap/43684 (was) Re: [Patch] Remove "set but unused" vars from rs6000.c.
References: <54308DF3-BDB7-4DF3-B110-D32104034069@sandoe-acoustics.co.uk> <20100409092445.GF2817@tyan-ft48-01.lab.bos.redhat.com> <150F6DEC-CCB7-4EBD-A914-8F7C335CD618@sandoe-acoustics.co.uk> <4BBF1D09.3040306@google.com>
Reply-to: Jakub Jelinek <jakub at redhat dot com>

On Fri, Apr 09, 2010 at 08:26:49AM -0400, Diego Novillo wrote:
> >  	case OPTION_static:
> > +#ifdef HAVE_LD_STATIC_DYNAMIC
> >  	  static_linking = 1;
> > +#endif
> >  
> >  	case OPTION_l:
> 
> Is the fall through intentional?  If so, could you add the comment
> /* FALLTHRU */?

I believe there should be break; instead of FALLTHRU -
this is about whether
gfortran -o foo -static
should complain or not.  It actually complains even without the
break, but for very different reason - lookup_option never returns
OPTION_static, guess PR31400 change was buggy.
So, static_linking is never actually set to non-zero.

	Jakub

Follow-Ups:
- Re: [Patch V3] Fix bootstrap/43684 (was) Re: [Patch] Remove "set but unused" vars from rs6000.c.
  - From: IainS
- Re: [Patch V3] Fix bootstrap/43684 (was) Re: [Patch] Remove "set but unused" vars from rs6000.c.
  - From: IainS

References:
- [Patch] Remove "set but unused" vars from rs6000.c.
  - From: IainS
- Re: [Patch] Remove "set but unused" vars from rs6000.c.
  - From: Jakub Jelinek
- [Patch V3] Fix bootstrap/43684 (was) Re: [Patch] Remove "set but unused" vars from rs6000.c.
  - From: IainS
- Re: [Patch V3] Fix bootstrap/43684 (was) Re: [Patch] Remove "set but unused" vars from rs6000.c.
  - From: Diego Novillo

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]