This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch V3] Fix bootstrap/43684 (was) Re: [Patch] Remove "set but unused" vars from rs6000.c.


On 4/9/10 07:35 , IainS wrote:

> gcc/fortran/
> 2010-04-09  Iain Sandoe  <iains@gcc.gnu.org>
> 
>     PR bootstrap/43684
>     * gfortranspec.c: Do not expose vars only used by
>     HAVE_LD_STATIC_DYNAMIC targets unless compiling for such.
[ ... ]
>     * config/rs6000/rs6000.c: Remove set, but unused, vars.
>     * config/darwin.c: Ditto.

Please mention which functions are affected by the change in each file.

>  	case OPTION_static:
> +#ifdef HAVE_LD_STATIC_DYNAMIC
>  	  static_linking = 1;
> +#endif
>  
>  	case OPTION_l:

Is the fall through intentional?  If so, could you add the comment
/* FALLTHRU */?

OK with those changes.


Diego.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]