This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Remove "set but unused" vars from rs6000.c.
- From: Jakub Jelinek <jakub at redhat dot com>
- To: IainS <developer at sandoe-acoustics dot co dot uk>, David Edelsohn <dje dot gcc at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 9 Apr 2010 11:24:45 +0200
- Subject: Re: [Patch] Remove "set but unused" vars from rs6000.c.
- References: <54308DF3-BDB7-4DF3-B110-D32104034069@sandoe-acoustics.co.uk>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Apr 08, 2010 at 09:50:09AM +0100, IainS wrote:
> as per title.
> I have done the mechanical job of removing the unused - I cannot be
> sure that the original author intended these vars to be unused.
Please provide a ChangeLog entry with every patch posted to gcc-patches.
The changes look good to me, though I can't approve them.
> Index: gcc/config/rs6000/rs6000.c
> ===================================================================
> --- gcc/config/rs6000/rs6000.c (revision 158099)
> +++ gcc/config/rs6000/rs6000.c (working copy)
> @@ -4183,7 +4183,7 @@
> rtx cc_op0, rtx cc_op1)
> {
> rtx tmp = gen_reg_rtx (V2SFmode);
> - rtx tmp1, max, min, equal_zero;
> + rtx tmp1, max, min;
>
> gcc_assert (TARGET_PAIRED_FLOAT);
> gcc_assert (GET_MODE (op0) == GET_MODE (op1));
> @@ -4210,7 +4210,6 @@
> tmp1 = gen_reg_rtx (V2SFmode);
> max = gen_reg_rtx (V2SFmode);
> min = gen_reg_rtx (V2SFmode);
> - equal_zero = gen_reg_rtx (V2SFmode);
>
> emit_insn (gen_subv2sf3 (tmp, cc_op0, cc_op1));
> emit_insn (gen_selv2sf4
> @@ -5412,14 +5411,14 @@
> else
> {
> rtx tmp3, mem;
> - rtx first, last;
> + rtx last;
>
> tmp1 = gen_reg_rtx (Pmode);
> tmp2 = gen_reg_rtx (Pmode);
> tmp3 = gen_reg_rtx (Pmode);
> mem = gen_const_mem (Pmode, tmp1);
>
> - first = emit_insn (gen_load_toc_v4_PIC_1b (gsym));
> + emit_insn (gen_load_toc_v4_PIC_1b (gsym));
> emit_move_insn (tmp1,
> gen_rtx_REG (Pmode, LR_REGNO));
> emit_move_insn (tmp2, mem);
> @@ -10148,7 +10147,7 @@
> tree fndecl = TREE_OPERAND (CALL_EXPR_FN (exp), 0);
> unsigned int fcode = DECL_FUNCTION_CODE (fndecl);
> tree arg0, arg1, arg2;
> - enum machine_mode mode0, mode1, mode2;
> + enum machine_mode mode0, mode1;
> rtx pat, op0, op1, op2;
> const struct builtin_description *d;
> size_t i;
> @@ -10168,7 +10167,6 @@
> op2 = expand_normal (arg2);
> mode0 = insn_data[d->icode].operand[0].mode;
> mode1 = insn_data[d->icode].operand[1].mode;
> - mode2 = insn_data[d->icode].operand[2].mode;
>
> /* Invalid arguments, bail out before generating bad rtl. */
> if (arg0 == error_mark_node
>
>
>
Jakub