This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix comments and indentation in tree-if-conv.c


On 4/6/10 20:34 , Sebastian Pop wrote:

while working on improving the if-conversion pass to solve
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43423
I fixed the comments, indentation, and the order of the static functions
in tree-if-conv.c.  The attached patches passed bootstrap and test
on amd64-linux.  Ok for trunk?

OK. Since you're here, could you fix these nits?


+/* Add condition COND into predicate list of basic block BB.  */
+
+static void
+add_to_predicate_list (basic_block bb, tree new_cond)

s/COND/NEW_COND/


+{
+  tree cond = (tree) bb->aux;
+
+  if (cond)

+/* Add condition COND into BB's predicate list.  PREV_COND is
+   existing condition.  */
+
+static tree
+add_to_dst_predicate_list (struct loop *loop, edge e,
+			   tree prev_cond, tree cond,
+			   gimple_stmt_iterator *gsi)

LOOP, E and GSI need documentation. There is no argument BB.



Thanks. Diego.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]