This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] S/390: Fix ICE with dynamic stack checking
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Andreas Krebbel <krebbel at linux dot vnet dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 5 Apr 2010 20:47:03 +0200
- Subject: Re: [PATCH] S/390: Fix ICE with dynamic stack checking
- References: <20100330133752.GA8142@bart>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Mar 30, 2010 at 03:37:52PM +0200, Andreas Krebbel wrote:
> the attached patch fixes a problem with the dynamic stack checks
> introduced with the arch dependent option -mstack-size on S/390.
>
> A bug causes an ICE if the function uses more than half the stack
> space at once.
>
> Committed to 4.3 and 4.4. 4.5/4.6 pending until branches are open
> again.
The testcase fails at least on the trunk and 4.4 branch for me and
from looking at the s390.c part of the change it seems the warning
is intentional.
This is what I'm going to regtest now, ok for trunk/4.4 if it passes?
2010-04-05 Jakub Jelinek <jakub@redhat.com>
* gcc.target/s390/stackcheck1.c: Add dg-warning.
--- gcc/testsuite/gcc.target/s390/stackcheck1.c.jj 2010-03-31 13:11:58.000000000 +0200
+++ gcc/testsuite/gcc.target/s390/stackcheck1.c 2010-04-05 20:35:25.000000000 +0200
@@ -11,4 +11,4 @@ foo ()
{
char a[2500];
bar (a);
-}
+} /* { dg-warning "more than half" } */
Jakub