This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Fix PR43464: update loop closed SSA form once copy prop is done
- From: Sebastian Pop <sebpop at gmail dot com>
- To: Richard Guenther <rguenther at suse dot de>
- Cc: Kenneth dot Zadeck at naturalbridge dot com, stevenb dot gcc at gmail dot com, gcc-patches at gcc dot gnu dot org
- Date: Thu, 1 Apr 2010 12:23:22 -0600
- Subject: Re: [patch] Fix PR43464: update loop closed SSA form once copy prop is done
- References: <571f6b511003231519y368f13c4xe611d9c0b6395707@mail.gmail.com> <87mxxywfog.fsf@moria.site> <cb9d34b21003241316o75198cb5n148f788a14125fa6@mail.gmail.com> <alpine.LNX.2.00.1003261048500.5522@zhemvz.fhfr.qr> <cb9d34b21003290926k7f14b0beyfbabe0bed5c2e015@mail.gmail.com> <k2lcb9d34b21003311146sc9225138t9891d4ca2d59905@mail.gmail.com> <alpine.LNX.2.00.1004011359230.5522@zhemvz.fhfr.qr> <o2jcb9d34b21004010742jd93a8f38r85ed6cff87e754b4@mail.gmail.com> <alpine.LNX.2.00.1004011644330.5522@zhemvz.fhfr.qr>
On Thu, Apr 1, 2010 at 08:48, Richard Guenther <rguenther@suse.de> wrote:
> Sort of. ?Only verify loop closed SSA if loop_state_satisifes_p
> has LCSSA.
done, see 0001
> ?Also add a param to verify_loop_closed_ssa whether
> verify_ssa should be called inside it (we do that from passes.c
> already, so avoid the duplicate).
done, see 0002
> ?For simplicity I'd just
> add TODO_verify_loops to the flags when loop state satisifes
> LCSSA in passes.c (which can then also avoid passing true to
> verify_loop_closed_ssa if ssa verification was already done).
>
This confuses me: why do you want to keep the TODO_verify_loops?
TODO_verify_loops won't have any effect on all the LNO passes
if I'm adding this change to execute_function_todo
if (current_loops && loops_state_satisfies_p (LOOP_CLOSED_SSA))
flags = flags & TODO_verify_loops;
Sebastian