This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Fix PR43464: update loop closed SSA form once copy prop is done
- From: Richard Guenther <rguenther at suse dot de>
- To: Sebastian Pop <sebpop at gmail dot com>
- Cc: Kenneth dot Zadeck at naturalbridge dot com, stevenb dot gcc at gmail dot com, gcc-patches at gcc dot gnu dot org
- Date: Thu, 1 Apr 2010 16:48:01 +0200 (CEST)
- Subject: Re: [patch] Fix PR43464: update loop closed SSA form once copy prop is done
- References: <571f6b511003231519y368f13c4xe611d9c0b6395707@mail.gmail.com> <87mxxywfog.fsf@moria.site> <cb9d34b21003241316o75198cb5n148f788a14125fa6@mail.gmail.com> <alpine.LNX.2.00.1003261048500.5522@zhemvz.fhfr.qr> <cb9d34b21003290926k7f14b0beyfbabe0bed5c2e015@mail.gmail.com> <k2lcb9d34b21003311146sc9225138t9891d4ca2d59905@mail.gmail.com> <alpine.LNX.2.00.1004011359230.5522@zhemvz.fhfr.qr> <o2jcb9d34b21004010742jd93a8f38r85ed6cff87e754b4@mail.gmail.com>
On Thu, 1 Apr 2010, Sebastian Pop wrote:
> On Thu, Apr 1, 2010 at 06:00, Richard Guenther <rguenther@suse.de> wrote:
> > On Wed, 31 Mar 2010, Sebastian Pop wrote:
> >
> >> On Mon, Mar 29, 2010 at 10:26, Sebastian Pop <sebpop@gmail.com> wrote:
> >> > PS: to reproduce the errors described here you would need the attached
> >> > patches.
> >>
> >> The attached patch systematically adds a TODO_verify_loops to all the
> >> passes that work at the LNO level. ?Would this be ok for trunk after
> >> testing and bootstrap?
> >
> > It would probably be better to automatically schedule this from
> > the pass manager if current_loops != NULL. ?Anyway, this looks like
> > stage1 material to me.
>
> You mean a patch like this?
Sort of. Only verify loop closed SSA if loop_state_satisifes_p
has LCSSA. Also add a param to verify_loop_closed_ssa whether
verify_ssa should be called inside it (we do that from passes.c
already, so avoid the duplicate). For simplicity I'd just
add TODO_verify_loops to the flags when loop state satisifes
LCSSA in passes.c (which can then also avoid passing true to
verify_loop_closed_ssa if ssa verification was already done).
Richard.
> Ok for 4.6 if it passes regstrap?
>
> Thanks,
> Sebastian
>
--
Richard Guenther <rguenther@suse.de>
Novell / SUSE Labs
SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 - GF: Markus Rex