This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: config patch to turn off -Wformat for systems that include it in -Wall
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Paolo Bonzini <bonzini at gnu dot org>
- Cc: Mike Stump <mikestump at comcast dot net>, gcc-patches Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 26 Mar 2010 12:13:02 +0000 (UTC)
- Subject: Re: config patch to turn off -Wformat for systems that include it in -Wall
- References: <55D5BFBD-51B9-48FA-8451-ED1F827F0F2D@comcast.net> <4BAC7F0A.1060704@gnu.org>
On Fri, 26 Mar 2010, Paolo Bonzini wrote:
> On 03/25/2010 07:55 PM, Mike Stump wrote:
> > This patch tuns off -Wformat for systems that include it in -Wall.
> > Apple's gcc would be one such system. On other systems, this
> > shouldn't have any effect. I originally wanted to put this into
> > config/mh-darwin, but those flags come before -Wall on the command
> > line and hence can't effect it.
> >
> > Ok?
>
> Ok for 4.5.
No, the patch is definitely wrong. We wouldn't have the support for
checking GCC-specific formats if we didn't want -Wformat enabled when
building GCC.
--
Joseph S. Myers
joseph@codesourcery.com