This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Enable softfp support on Solaris 2/x86 (PR target/39048)
On Tue, 23 Mar 2010, Rainer Orth wrote:
> "Joseph S. Myers" <joseph@codesourcery.com> writes:
>
> > I believe that in the interests of maintainability we should define all
> > %inherit relations between target-independent versions in libgcc-std.ver.
> > As you have seen, if a particular version is empty on some targets the
> > inheritance will automatically end up being from the previous non-empty
> > version. That is, we should apply something like this patch (untested,
> > also fixes the missing exports of __unordxf2 and __unordtf2) and then make
> > further fixes on top of it.
>
> I've now tested my patch with two modifications: removing the %inherit
> and removing the 32-bit/64-bit conditionals I originally had in
> libgcc-sol2.ver. Since the libgcc_s.so.1 framework takes care to only
> include symbols in the version map that are actually defined, there's no
> point in having them. The version info, as checked with pvs -dsvo, is
> unchanged from what I had before.
I think this revised patch has the correct set of symbols and versions.
My patch of course needs someone to review it.
--
Joseph S. Myers
joseph@codesourcery.com